Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension no longer starts with vscode as of 0.1.0 #92

Closed
DetachHead opened this issue Feb 16, 2022 · 5 comments · Fixed by #94
Closed

extension no longer starts with vscode as of 0.1.0 #92

DetachHead opened this issue Feb 16, 2022 · 5 comments · Fixed by #94
Labels

Comments

@DetachHead
Copy link

the tests tab is not present
image

there are no run icons on the tests
image

and attempting to run any playwright commands from the F1 menu results in the following error:
image

@mxschmitt
Copy link
Member

Could you provide us a repro repository? Which Playwright version are you using? 1.19+ is required.

@DetachHead
Copy link
Author

Which Playwright version are you using?

1.19.1

Could you provide us a repro repository?

it happens on a blank repo generated with npm init playwright, however i can only reproduce it on one machine but not my other one. here's the output from npx envinfo --preset playwright --markdown, i'm not sure what other info i can provide because i couldn't see anything noteworthy in in the output logs

System:

  • OS: Windows 10 10.0.18363
  • Memory: 1.12 GB / 15.78 GB

Binaries:

  • Node: 16.9.1 - C:\Program Files\nodejs\node.EXE
  • npm: 7.24.1 - C:\Program Files\nodejs\npm.CMD

Languages:

  • Bash: 5.0.17 - C:\WINDOWS\system32\bash.EXE

@mxschmitt
Copy link
Member

I tried to reproduce on Windows, but was unfortunately not able to. So the playwright-demo folder is the folder which npm init playwright has created?

and attempting to run any playwright commands from the F1 menu results in the following error:

It seems like that the original activation of the extension was not successful, thats why all the commands are not working. Could you check if inside the Output Log (Extension Host) something gets printed regarding Playwright?

Which Visual Studio Code version are you using?

@DetachHead
Copy link
Author

that fix seemed to work, thanks!

@DetachHead
Copy link
Author

@mxschmitt though it is annoying having to manually run one of the tasks whenever i open my project, could this issue be re-opened until that's resolved? or should i make a new issue?

So the playwright-demo folder is the folder which npm init playwright has created?

yep

Could you check if inside the Output Log (Extension Host) something gets printed regarding Playwright?

nothing playwright related on launch:

[2022-02-17 09:35:42.073] [exthost] [info] Extension host with pid 24380 started
[2022-02-17 09:35:42.073] [exthost] [info] Skipping acquiring lock for c:\Users\user\AppData\Roaming\Code\User\workspaceStorage\f6ef7d513360f660b597a27ffa6448d0.
[2022-02-17 09:35:42.199] [exthost] [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication, startup: false, activationEvent: 'onAuthenticationRequest:microsoft'
[2022-02-17 09:35:42.221] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch, startup: true, activationEvent: '*'
[2022-02-17 09:35:42.229] [exthost] [info] ExtensionService#_doActivateExtension vscode.git-base, startup: true, activationEvent: '*', root cause: vscode.github
[2022-02-17 09:35:42.238] [exthost] [info] ExtensionService#_doActivateExtension vscode.npm, startup: true, activationEvent: 'workspaceContains:package.json'
[2022-02-17 09:35:42.315] [exthost] [info] ExtensionService#_doActivateExtension vscode.git, startup: true, activationEvent: '*'
[2022-02-17 09:35:42.339] [exthost] [info] ExtensionService#_doActivateExtension vscode.github, startup: true, activationEvent: '*'
[2022-02-17 09:35:42.401] [exthost] [info] ExtensionService#_doActivateExtension vscode.github-authentication, startup: false, activationEvent: 'onAuthenticationRequest:github'
[2022-02-17 09:35:43.779] [exthost] [info] Eager extensions activated
[2022-02-17 09:35:43.793] [exthost] [info] ExtensionService#_doActivateExtension vscode.emmet, startup: false, activationEvent: 'onStartupFinished'
[2022-02-17 09:35:43.806] [exthost] [info] ExtensionService#_doActivateExtension vscode.merge-conflict, startup: false, activationEvent: 'onStartupFinished'
[2022-02-17 09:35:43.814] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode-remote.remote-wsl-recommender, startup: false, activationEvent: 'onStartupFinished'

however when i run one of the playwright tasks it now successfully loads the extension and this line appears:

[2022-02-17 09:39:18.447] [exthost] [info] ExtensionService#_doActivateExtension ms-playwright.playwright, startup: false, activationEvent: 'onCommand:pw.extension.refreshTests'

Which Visual Studio Code version are you using?

Version: 1.64.2 (user setup)
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:28.252Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.18363

@DetachHead DetachHead changed the title extension seems to be completely broken in 0.1.0 extension no longer starts with vscode as of 0.1.0 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants