fix(reuse): disable tracing #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Mar 29, 2023
"Show browser" mode forces context reuse that survives over multiple test runs. Playwright Test sets up `tracesDir` inside the `test-results` folder, so it will be removed between runs. When context is reused, its ongoing tracing will fail with ENOENT because trace files were suddenly removed. So we disable tracing in this case.
dgozman
force-pushed
the
disable-trace-when-reusing
branch
from
206e4da
to
0bd85d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Show browser" mode forces context reuse that survives over multiple test runs. Playwright Test sets up
tracesDirinside thetest-resultsfolder, so it will be removed between runs. When context is reused, its ongoing tracing will fail with ENOENT because trace files were suddenly removed. So we disable tracing in this case.Fixes microsoft/playwright#21993.