fix(webkit): allow fufilling requests to redirects (#1830)

microsoft · Apr 16, 2020 · 036f9e5 · 036f9e5
1 parent 5ec2c58
commit 036f9e5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/webkit/wkInterceptableRequest.ts b/src/webkit/wkInterceptableRequest.ts
@@ -69,7 +69,7 @@ export class WKInterceptableRequest implements network.RouteDelegate {
     await this._interceptedPromise;
 
     const base64Encoded = !!response.body && !helper.isString(response.body);
-    const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : undefined;
+    const responseBody = response.body ? (base64Encoded ? response.body.toString('base64') : response.body as string) : '';
 
     const responseHeaders: { [s: string]: string; } = {};
     if (response.headers) {

diff --git a/test/interception.spec.js b/test/interception.spec.js
@@ -368,8 +368,7 @@ describe('Page.route', function() {
     expect(response.ok()).toBe(true);
     expect(intercepted).toBe(true);
   });
-  // WebKit crashes. Firefox succeeds, but then fails to close.
-  it.fail(FFOX || WEBKIT)('should create a redirect', async({page, server}) => {
+  it('should create a redirect', async({page, server}) => {
     await page.goto(server.PREFIX + '/empty.html');
     await page.route('**/*', async(route, request) => {
       if (request.url() !== server.PREFIX + '/redirect_this')