fix(extensions): do not enable screencast for background pages (#4919)

microsoft · Jan 6, 2021 · 0a2fe62 · 0a2fe62
1 parent 8fd34c6
commit 0a2fe62
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/server/chromium/crPage.ts b/src/server/chromium/crPage.ts
@@ -461,7 +461,7 @@ class FrameSession {
       promises.push(this._evaluateOnNewDocument(source, 'main'));
     for (const source of this._crPage._page._evaluateOnNewDocumentSources)
       promises.push(this._evaluateOnNewDocument(source, 'main'));
-    if (this._isMainFrame() && this._crPage._browserContext._options.recordVideo) {
+    if (this._isMainFrame() && this._crPage._browserContext._options.recordVideo && hasUIWindow) {
       const size = this._crPage._browserContext._options.recordVideo.size || this._crPage._browserContext._options.viewport || { width: 1280, height: 720 };
       const screencastId = createGuid();
       const outputFile = path.join(this._crPage._browserContext._options.recordVideo.dir, screencastId + '.webm');

diff --git a/test/chromium/launcher.spec.ts b/test/chromium/launcher.spec.ts
@@ -77,6 +77,32 @@ it('should return background pages', (test, { browserName }) => {
   await context.close();
 });
 
+it('should return background pages when recording video', (test, { browserName }) => {
+  test.skip(browserName !== 'chromium');
+}, async ({browserType, testInfo, browserOptions, createUserDataDir}) => {
+  const userDataDir = await createUserDataDir();
+  const extensionPath = path.join(__dirname, '..', 'assets', 'simple-extension');
+  const extensionOptions = {...browserOptions,
+    headless: false,
+    args: [
+      `--disable-extensions-except=${extensionPath}`,
+      `--load-extension=${extensionPath}`,
+    ],
+    recordVideo: {
+      dir: testInfo.outputPath(''),
+    },
+  };
+  const context = await browserType.launchPersistentContext(userDataDir, extensionOptions) as ChromiumBrowserContext;
+  const backgroundPages = context.backgroundPages();
+  const backgroundPage = backgroundPages.length
+    ? backgroundPages[0]
+    : await context.waitForEvent('backgroundpage');
+  expect(backgroundPage).toBeTruthy();
+  expect(context.backgroundPages()).toContain(backgroundPage);
+  expect(context.pages()).not.toContain(backgroundPage);
+  await context.close();
+});
+
 it('should not create pages automatically', (test, { browserName }) => {
   test.skip(browserName !== 'chromium');
 }, async ({browserType, browserOptions}) => {