Skip to content

Commit

Permalink
Remove some nowaitfor
Browse files Browse the repository at this point in the history
  • Loading branch information
yury-s committed Dec 4, 2023
1 parent 16ad72f commit 11f33b5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/page/interception.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ it('should intercept after a service worker', async ({ page, server, browserName
contentType: 'text/css',
body: 'responseFromInterception:' + name
});
}, { noWaitForFinish: true });
});

// Page route is applied after service worker fetch event.
const swResponse2 = await page.evaluate(() => window['fetchDummy']('foo'));
Expand Down
2 changes: 1 addition & 1 deletion tests/page/page-route.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ it('should show custom HTTP headers', async ({ page, server }) => {
it('should work with redirect inside sync XHR', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE);
server.setRedirect('/logo.png', '/pptr.png');
await page.route('**/*', route => route.continue(), { noWaitForFinish: true });
await page.route('**/*', route => route.continue());
const status = await page.evaluate(async () => {
const request = new XMLHttpRequest();
request.open('GET', '/logo.png', false); // `false` makes the request synchronous
Expand Down

0 comments on commit 11f33b5

Please sign in to comment.