test: mark some tests as skipped (3)

microsoft · Mar 2, 2020 · 342e79c · 342e79c
1 parent 2f98b5e
commit 342e79c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/test/chromium/headful.spec.js b/test/chromium/headful.spec.js
@@ -62,7 +62,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows
       await removeUserDataDir(userDataDir);
     });
     // TODO: Support OOOPIF. @see https://github.com/GoogleChrome/puppeteer/issues/2548
-    xit('OOPIF: should report google.com frame', async({server}) => {
+    it.fail(true)('OOPIF: should report google.com frame', async({server}) => {
       // https://google.com is isolated by default in Chromium embedder.
       const browser = await playwright.launch(headfulOptions);
       const page = await browser.newPage();

diff --git a/test/chromium/oopif.spec.js b/test/chromium/oopif.spec.js
@@ -41,7 +41,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
       await state.browser.close();
       state.browser = null;
     });
-    xit('should report oopif frames', async function({browser, page, server, context}) {
+    it.fail(true)('should report oopif frames', async function({browser, page, server, context}) {
       const browserSession = await browser.createBrowserSession();
       await browserSession.send('Target.setDiscoverTargets', { discover: true });
       const oopifs = [];

diff --git a/test/click.spec.js b/test/click.spec.js
@@ -308,7 +308,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
     // @see https://github.com/GoogleChrome/puppeteer/issues/4110
     // @see https://bugs.chromium.org/p/chromium/issues/detail?id=986390
     // @see https://chromium-review.googlesource.com/c/chromium/src/+/1742784
-    xit('should click the button with fixed position inside an iframe', async({page, server}) => {
+    it.fail(true)('should click the button with fixed position inside an iframe', async({page, server}) => {
       await page.goto(server.EMPTY_PAGE);
       await page.setViewportSize({width: 500, height: 500});
       await page.setContent('<div style="width:100px;height:2000px">spacer</div>');
@@ -519,7 +519,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
       await page.click('button');
       expect(await page.evaluate('window.clicked')).toBe(true);
     });
-    xit('should fail to click a button animated via CSS animations and setInterval', async({page}) => {
+    it.fail(true)('should fail to click a button animated via CSS animations and setInterval', async({page}) => {
       // This test has a setInterval that consistently animates a button.
       // It checks that we detect the button to be continuously animating, and never try to click it.
       // This test exposes two issues:

diff --git a/test/features/permissions.spec.js b/test/features/permissions.spec.js
@@ -27,7 +27,7 @@ module.exports.describe = function({testRunner, expect, WEBKIT}) {
   const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
 
   // Permissions API is not implemented in WebKit (see https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API)
-  describe.fail(WEBKIT)('Permissions', function() {
+  describe.skip(WEBKIT)('Permissions', function() {
     function getPermission(page, name) {
       return page.evaluate(name => navigator.permissions.query({name}).then(result => result.state), name);
     }

diff --git a/test/mouse.spec.js b/test/mouse.spec.js
@@ -149,8 +149,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
       expect(await page.evaluate('result')).toEqual({x: 30, y: 40});
       await context.close();
     });
-    describe('Drag and Drop', function() {
-      xit('should work', async({server, page}) => {
+    xdescribe('Drag and Drop', function() {
+      it('should work', async({server, page}) => {
         await page.goto(server.PREFIX + '/drag-n-drop.html');
         await page.hover('#source');
         await page.mouse.down();