Skip to content

Commit

Permalink
test: use net8.0 for webview2 tests (#28665)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt committed Dec 15, 2023
1 parent 86ef739 commit 35b61b7
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests_webview2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18
- uses: actions/setup-dotnet@v2
- uses: actions/setup-dotnet@v3
with:
dotnet-version: '6.0.x'
dotnet-version: '8.0.x'
- run: npm ci
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
Expand Down
2 changes: 1 addition & 1 deletion tests/webview2/globalSetup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import playwright from 'playwright';

export default async () => {
const cdpPort = 9876;
const spawnedProcess = childProcess.spawn(path.join(__dirname, 'webview2-app/bin/Debug/net6.0-windows/webview2.exe'), {
const spawnedProcess = childProcess.spawn(path.join(__dirname, 'webview2-app/bin/Debug/net8.0-windows/webview2.exe'), {
shell: true,
env: {
...process.env,
Expand Down
2 changes: 1 addition & 1 deletion tests/webview2/webView2Test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const webView2Test = baseTest.extend<TraceViewerFixtures>(traceViewerFixt
browser: [async ({ playwright }, use, testInfo) => {
const cdpPort = 10000 + testInfo.workerIndex;
const spawnedProcess = new TestChildProcess({
command: [path.join(__dirname, 'webview2-app/bin/Debug/net6.0-windows/webview2.exe')],
command: [path.join(__dirname, 'webview2-app/bin/Debug/net8.0-windows/webview2.exe')],
shell: true,
env: {
...process.env,
Expand Down
4 changes: 2 additions & 2 deletions tests/webview2/webview2-app/webview2.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFramework>net6.0-windows</TargetFramework>
<TargetFramework>net8.0-windows</TargetFramework>
<Nullable>enable</Nullable>
<UseWindowsForms>true</UseWindowsForms>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Web.WebView2" Version="1.0.1293.44" />
<PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2210.55" />
</ItemGroup>

</Project>

0 comments on commit 35b61b7

Please sign in to comment.