Skip to content

Commit

Permalink
feat(firefox): roll to r1456 (#31375)
Browse files Browse the repository at this point in the history
Fixes #31328
Fixes #30837

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
  • Loading branch information
3 people committed Jun 19, 2024
1 parent a7958ff commit 45ee318
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/playwright-core/browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
{
"name": "firefox",
"revision": "1454",
"revision": "1456",
"installByDefault": true,
"browserVersion": "127.0"
},
Expand Down
3 changes: 1 addition & 2 deletions tests/library/video.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,8 @@ it.describe('screencast', () => {
expectRedFrames(videoFile, size);
});

it('should continue recording main page after popup closes', async ({ browser, browserName, trace, headless, isWindows }, testInfo) => {
it('should continue recording main page after popup closes', async ({ browser, browserName }, testInfo) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/30837' });
it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/30837');
// Firefox does not have a mobile variant and has a large minimum size (500 on windows and 450 elsewhere).
const size = browserName === 'firefox' ? { width: 500, height: 400 } : { width: 320, height: 240 };
const context = await browser.newContext({
Expand Down
3 changes: 1 addition & 2 deletions tests/page/page-emulate-media.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,8 @@ it('should emulate reduced motion', async ({ page }) => {
await page.emulateMedia({ reducedMotion: null });
});

it('should keep reduced motion and color emulation after reload', async ({ page, server, browserName }) => {
it('should keep reduced motion and color emulation after reload', async ({ page, server }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/31328' });
it.fixme(browserName === 'firefox');

// Pre-conditions
expect(await page.evaluate(() => matchMedia('(prefers-reduced-motion: reduce)').matches)).toEqual(false);
Expand Down

0 comments on commit 45ee318

Please sign in to comment.