fix(logs): restore pw:browser logs after launch has finished (#5527)

microsoft · Feb 20, 2021 · 46c8c29 · 46c8c29
1 parent e2a935b
commit 46c8c29
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/server/progress.ts b/src/server/progress.ts
@@ -70,10 +70,10 @@ export class ProgressController {
 
     const progress: Progress = {
       log: message => {
-        if (this._state === 'running') {
+        if (this._state === 'running')
           this.metadata.log.push(message);
-          this.instrumentation.onCallLog(this._logName, message, this.sdkObject, this.metadata);
-        }
+        // Note: we might be sending logs after progress has finished, for example browser logs.
+        this.instrumentation.onCallLog(this._logName, message, this.sdkObject, this.metadata);
       },
       timeUntilDeadline: () => this._deadline ? this._deadline - monotonicTime() : 2147483647, // 2^31-1 safe setTimeout in Node.
       isRunning: () => this._state === 'running',