fix(codegen): missing await before newPage.goto (#6253)

microsoft · Apr 21, 2021 · 640b10c · 640b10c
1 parent 85e2db2
commit 640b10c
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/server/supplements/recorder/csharp.ts b/src/server/supplements/recorder/csharp.ts
@@ -35,7 +35,7 @@ export class CSharpLanguageGenerator implements LanguageGenerator {
     if (action.name === 'openPage') {
       formatter.add(`var ${pageAlias} = await context.NewPageAsync();`);
       if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/')
-        formatter.add(`${pageAlias}.GoToAsync('${action.url}');`);
+        formatter.add(`await ${pageAlias}.GoToAsync(${quote(action.url)});`);
       return formatter.format();
     }
 

diff --git a/src/server/supplements/recorder/javascript.ts b/src/server/supplements/recorder/javascript.ts
@@ -35,7 +35,7 @@ export class JavaScriptLanguageGenerator implements LanguageGenerator {
     if (action.name === 'openPage') {
       formatter.add(`const ${pageAlias} = await context.newPage();`);
       if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/')
-        formatter.add(`${pageAlias}.goto('${action.url}');`);
+        formatter.add(`await ${pageAlias}.goto(${quote(action.url)});`);
       return formatter.format();
     }
 

diff --git a/src/server/supplements/recorder/python.ts b/src/server/supplements/recorder/python.ts
@@ -47,7 +47,7 @@ export class PythonLanguageGenerator implements LanguageGenerator {
     if (action.name === 'openPage') {
       formatter.add(`${pageAlias} = ${this._awaitPrefix}context.new_page()`);
       if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/')
-        formatter.add(`${pageAlias}.goto('${action.url}')`);
+        formatter.add(`${this._awaitPrefix}${pageAlias}.goto(${quote(action.url)})`);
       return formatter.format();
     }
 

diff --git a/tests/cli/cli-codegen-2.spec.ts b/tests/cli/cli-codegen-2.spec.ts
@@ -376,7 +376,15 @@ await page.ClickAsync(\"text=click me\");`);
       expect(sources.get('<javascript>').text).toContain(`
   // Open new page
   const page1 = await context.newPage();
-  page1.goto('about:blank?foo');`);
+  await page1.goto('about:blank?foo');`);
+      expect(sources.get('<async python>').text).toContain(`
+    # Open new page
+    page1 = await context.new_page()
+    await page1.goto("about:blank?foo")`);
+      expect(sources.get('<csharp>').text).toContain(`
+// Open new page
+var page1 = await context.NewPageAsync();
+await page1.GoToAsync("about:blank?foo");`);
     } else if (browserName === 'firefox') {
       expect(sources.get('<javascript>').text).toContain(`
   // Click text=link