fix(webkit): pass popup tests (#1138)

microsoft · Feb 27, 2020 · 6b6a671 · 6b6a671
1 parent d41342f
commit 6b6a671
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
   "playwright": {
     "chromium_revision": "744254",
     "firefox_revision": "1031",
-    "webkit_revision": "1159"
+    "webkit_revision": "1162"
   },
   "scripts": {
     "ctest": "cross-env BROWSER=chromium node test/test.js",

diff --git a/test/popup.spec.js b/test/popup.spec.js
@@ -20,7 +20,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
   const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
 
   describe('window.open', function() {
-    it.skip(CHROMIUM || WEBKIT)('should inherit user agent from browser context', async function({browser, server}) {
+    it.skip(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) {
       const context = await browser.newContext({
         userAgent: 'hey'
       });
@@ -61,9 +61,9 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
       await context.close();
       expect(hasTouch).toBe(true);
     });
-    it.skip(CHROMIUM || WEBKIT)('should inherit viewport size from browser context', async function({browser, server}) {
+    it.skip(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) {
       const context = await browser.newContext({
-        viewport: { width: 400, height: 500, isMobile: true }
+        viewport: { width: 400, height: 500 }
       });
       const page = await context.newPage();
       await page.goto(server.EMPTY_PAGE);