fix(installer): release lock if things go south (#5125)

References #5110
microsoft · Jan 23, 2021 · 74816e4 · 74816e4
1 parent b7fd0cd
commit 74816e4
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/install/installer.ts b/src/install/installer.ts
@@ -57,10 +57,13 @@ export async function installBrowsersWithProgressBar(packagePath: string, browse
   });
   const linksDir = path.join(browsersPath, '.links');
 
-  await fsMkdirAsync(linksDir,  { recursive: true });
-  await fsWriteFileAsync(path.join(linksDir, sha1(packagePath)), packagePath);
-  await validateCache(packagePath, browsersPath, linksDir, browserNames);
-  await releaseLock();
+  try {
+    await fsMkdirAsync(linksDir,  { recursive: true });
+    await fsWriteFileAsync(path.join(linksDir, sha1(packagePath)), packagePath);
+    await validateCache(packagePath, browsersPath, linksDir, browserNames);
+  } finally {
+    await releaseLock();
+  }
 }
 
 async function validateCache(packagePath: string, browsersPath: string, linksDir: string, browserNames?: browserPaths.BrowserName[]) {