Skip to content

Commit

Permalink
chery-pick(#17918): docs: AriaRole is enum (#17921)
Browse files Browse the repository at this point in the history
This PR cherry-picks the following commits:

- 946994c

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
playwrightmachine and github-actions[bot] committed Oct 8, 2022
1 parent af0d293 commit 75aaaac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/src/release-notes-java.md
Expand Up @@ -21,7 +21,7 @@ page.getByLabel("User Name").fill("John");

page.getByLabel("Password").fill("secret-password");

page.getByRole("button", new Page.GetByRoleOptions().setName("Sign in")).click();
page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Sign in")).click();

assertThat(page.getByText("Welcome, John!")).isVisible();
```
Expand All @@ -37,7 +37,7 @@ All the same methods are also available on [Locator], [FrameLocator] and [Frame]
- [`method: LocatorAssertions.toHaveAttribute`] with an empty value does not match missing attribute anymore. For example, the following snippet will succeed when `button` **does not** have a `disabled` attribute.

```js
assertThat(page.getByRole("button")).hasAttribute("disabled", "");
assertThat(page.getByRole(AriaRole.BUTTON)).hasAttribute("disabled", "");
```

### Browser Versions
Expand Down

0 comments on commit 75aaaac

Please sign in to comment.