chore: fix build warnings (#31616)

microsoft · Jul 11, 2024 · 77e5063 · 77e5063
1 parent 89eef55
commit 77e5063
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/playwright-core/src/server/injected/clock.ts b/packages/playwright-core/src/server/injected/clock.ts
@@ -301,7 +301,11 @@ export class ClockController {
       if (typeof timer.func !== 'function') {
         let error: Error | undefined;
         try {
-          (() => { eval(timer.func); })();
+          // Using global this is not correct here,
+          // but it is already broken since the eval scope is different from the one
+          // on the original call site.
+          // eslint-disable-next-line no-restricted-globals
+          (() => { globalThis.eval(timer.func); })();
         } catch (e) {
           error = e;
         }

diff --git a/packages/playwright/bundles/babel/package.json b/packages/playwright/bundles/babel/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.1",
   "private": true,
   "scripts": {
-    "esbuild": "esbuild ./src/babelBundleImpl.ts --bundle --outdir=../../lib/transform --format=cjs --platform=node --target=ES2019",
+    "esbuild": "esbuild ./src/babelBundleImpl.ts --bundle --outdir=../../lib/transform --format=cjs --platform=node --target=ES2019 --external:playwright",
     "build": "npm run esbuild -- --minify",
     "watch": "npm run esbuild -- --watch --sourcemap",
     "generate-license": "node ../../../../utils/generate_third_party_notice.js"