browser(firefox): send requestFailed on network error (#1816)

microsoft · Apr 16, 2020 · 77f1a70 · 77f1a70
1 parent 0d4f73f
commit 77f1a70
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/browser_patches/firefox/BUILD_NUMBER b/browser_patches/firefox/BUILD_NUMBER
@@ -1 +1 @@
-1082
+1083
diff --git a/browser_patches/firefox/patches/bootstrap.diff b/browser_patches/firefox/patches/bootstrap.diff
@@ -1400,10 +1400,10 @@ index 0000000000000000000000000000000000000000..b8e6649fb91be6cd72b000426fb4d582
 +
 diff --git a/juggler/NetworkObserver.js b/juggler/NetworkObserver.js
 new file mode 100644
-index 0000000000000000000000000000000000000000..b8a98b058ea36f85fddfa21e992e2d0674c11e3d
+index 0000000000000000000000000000000000000000..1a55b5498c18d2403eab21fe9149242f286157d4
 --- /dev/null
 +++ b/juggler/NetworkObserver.js
-@@ -0,0 +1,789 @@
+@@ -0,0 +1,794 @@
 +"use strict";
 +
 +const {EventEmitter} = ChromeUtils.import('resource://gre/modules/EventEmitter.jsm');
@@ -2024,9 +2024,14 @@ index 0000000000000000000000000000000000000000..b8a98b058ea36f85fddfa21e992e2d06
 +    if (this._disposed)
 +      return;
 +
-+    const body = this._chunks.join('');
++    if (aStatusCode === 0) {
++      const body = this._chunks.join('');
++      this._networkObserver._onResponseFinished(this._pageNetwork, this._httpChannel, body);
++    } else {
++      this._networkObserver._sendOnRequestFailed(this._pageNetwork, this._httpChannel, aStatusCode);
++    }
++
 +    delete this._chunks;
-+    this._networkObserver._onResponseFinished(this._pageNetwork, this._httpChannel, body);
 +    this.dispose();
 +  }
 +