Skip to content

Commit

Permalink
devops: rename env variable (#5379)
Browse files Browse the repository at this point in the history
goma searches for all `GOMA_*` env variables and fails if it doesn't
understand any.

To avoid this, rename our `GOMA_LOGIN_COOKIE` env variable into a
`PLAYWRIGHT_GOMA_LOGIN_COOKIE`.
  • Loading branch information
aslushnikov committed Feb 9, 2021
1 parent d5a51a2 commit 9095449
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions browser_patches/chromium/goma.sh
Expand Up @@ -22,8 +22,10 @@ if [[ $1 == "--help" ]]; then
elif [[ $1 == "login" ]]; then
python ./third_party/goma/goma_auth.py login
elif [[ $1 == "start" ]]; then
if [[ ! -z "$GOMA_LOGIN_COOKIE" ]]; then
echo "$GOMA_LOGIN_COOKIE" > "$HOME/.goma_oauth2_config"
# We have to prefix ENV with `PLAYWRIGHT` since `GOMA_` env variables
# have special treatment by goma.
if [[ ! -z "$PLAYWRIGHT_GOMA_LOGIN_COOKIE" ]]; then
echo "$PLAYWRIGHT_GOMA_LOGIN_COOKIE" > "$HOME/.goma_oauth2_config"
fi
if [[ ! -f "$HOME/.goma_oauth2_config" ]]; then
echo "ERROR: goma is not logged in!"
Expand Down

0 comments on commit 9095449

Please sign in to comment.