Skip to content

Commit

Permalink
feat(browser): roll Firefox to r1059 (#1551)
Browse files Browse the repository at this point in the history
This fixes flaky user gesture in evaluation.
  • Loading branch information
aslushnikov committed Mar 26, 2020
1 parent b1c156f commit b24262b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -9,7 +9,7 @@
"main": "index.js",
"playwright": {
"chromium_revision": "751710",
"firefox_revision": "1058",
"firefox_revision": "1059",
"webkit_revision": "1182"
},
"scripts": {
Expand Down
4 changes: 1 addition & 3 deletions test/evaluation.spec.js
Expand Up @@ -233,9 +233,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
await page.evaluate(e => e.textContent, element).catch(e => error = e);
expect(error.message).toContain('JSHandle is disposed');
});
it.fail(FFOX)('should simulate a user gesture', async({page, server}) => {
// flaky linux: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496501774
// flaky win: https://github.com/microsoft/playwright/pull/1323/checks?check_run_id=501701278
it('should simulate a user gesture', async({page, server}) => {
const result = await page.evaluate(() => {
document.body.appendChild(document.createTextNode('test'));
document.execCommand('selectAll');
Expand Down

0 comments on commit b24262b

Please sign in to comment.