Skip to content

Commit

Permalink
test(chromium): mark passing popup tests as passing (#1297)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgozman committed Mar 9, 2020
1 parent ca5ce7d commit cf46f1b
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions test/popup.spec.js
Expand Up @@ -83,7 +83,6 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
expect(online).toBe(false);
});
it('should inherit http credentials from browser context', async function({browser, server}) {
// Use unique user/password since Chromium caches credentials per origin.
server.setAuth('/title.html', 'user', 'pass');
const context = await browser.newContext({
httpCredentials: { username: 'user', password: 'pass' }
Expand Down Expand Up @@ -123,7 +122,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
await context.close();
expect(size).toEqual({width: 400, height: 500});
});
it.fail(CHROMIUM)('should apply addInitScript from browser context', async function({browser, server}) {
it('should apply addInitScript from browser context', async function({browser, server}) {
const context = await browser.newContext();
await context.addInitScript(() => window.injected = 123);
const page = await context.newPage();
Expand All @@ -135,7 +134,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
await context.close();
expect(injected).toBe(123);
});
it.fail(CHROMIUM || FFOX)('should expose function from browser context', async function({browser, server}) {
it.fail(FFOX)('should expose function from browser context', async function({browser, server}) {
const context = await browser.newContext();
await context.exposeFunction('add', (a, b) => a + b);
const page = await context.newPage();
Expand Down

0 comments on commit cf46f1b

Please sign in to comment.