chore: friendlier install failure message (#5281)

microsoft · Feb 4, 2021 · dd9b51d · dd9b51d
1 parent 3126fee
commit dd9b51d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/cli/cli.ts b/src/cli/cli.ts
@@ -130,6 +130,13 @@ program
     .command('install [browserType...]')
     .description('Ensure browsers necessary for this version of Playwright are installed')
     .action(function(browserType) {
+      const allBrowsers = new Set(['chromium', 'firefox', 'webkit']);
+      for (const type of browserType) {
+        if (!allBrowsers.has(type)) {
+          console.log(`Invalid browser name: '${type}'. Expecting 'chromium', 'firefox' or 'webkit'.`);
+          process.exit(1);
+        }
+      }
       installBrowsers(browserType.length ? browserType : undefined).catch((e: any) => {
         console.log(`Failed to install browsers\n${e}`);
         process.exit(1);