fix(click): revert layout shift logic

microsoft · Dec 1, 2021 · f096b39 · f096b39
1 parent 5c93066
commit f096b39
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/playwright-core/src/server/dom.ts b/packages/playwright-core/src/server/dom.ts
@@ -407,7 +407,7 @@ export class ElementHandle<T extends Node = Node> extends js.JSHandle<T> {
     const point = roundPoint(maybePoint);
     progress.metadata.point = point;
 
-    if (process.env.PLAYWRIGHT_NO_LAYOUT_SHIFT_CHECK)
+    if (!process.env.PLAYWRIGHT_LAYOUT_SHIFT_CHECK)
       return this._finishPointerAction(progress, actionName, point, options, action);
     else
       return this._finishPointerActionDetectLayoutShift(progress, actionName, point, options, action);

diff --git a/tests/hit-target.spec.ts b/tests/hit-target.spec.ts
@@ -45,6 +45,8 @@ it('should block all events when hit target is wrong', async ({ page, server })
 });
 
 it('should block click when mousedown succeeds but mouseup fails', async ({ page, server }) => {
+  it.fixme();
+
   await page.goto(server.PREFIX + '/input/button.html');
   await page.$eval('button', button => {
     button.addEventListener('mousedown', () => {
@@ -82,6 +84,8 @@ it('should click when element detaches in mousedown', async ({ page, server }) =
 });
 
 it('should not block programmatic events', async ({ page, server }) => {
+  it.fixme();
+
   await page.goto(server.PREFIX + '/input/button.html');
   await page.$eval('button', button => {
     button.addEventListener('mousedown', () => {