Skip to content

Commit

Permalink
feat(webkit): use consistent user agent for headful and headless (#756)
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelfeldman committed Jan 30, 2020
1 parent ce72198 commit f44d660
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/webkit/wkBrowser.ts
Expand Up @@ -28,6 +28,8 @@ import { WKConnection, WKSession, kPageProxyMessageReceived, PageProxyMessageRec
import { WKPageProxy } from './wkPageProxy';
import * as platform from '../platform';

const DEFAULT_USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.4 Safari/605.1.15';

export class WKBrowser extends platform.EventEmitter implements Browser {
private readonly _connection: WKConnection;
private readonly _browserSession: WKSession;
Expand Down Expand Up @@ -73,6 +75,7 @@ export class WKBrowser extends platform.EventEmitter implements Browser {

async newContext(options: BrowserContextOptions = {}): Promise<BrowserContext> {
const { browserContextId } = await this._browserSession.send('Browser.createContext');
options.userAgent = options.userAgent || DEFAULT_USER_AGENT;
const context = this._createBrowserContext(browserContextId, options);
if (options.ignoreHTTPSErrors)
await this._browserSession.send('Browser.setIgnoreCertificateErrors', { browserContextId, ignore: true });
Expand Down

0 comments on commit f44d660

Please sign in to comment.