Skip to content

Commit

Permalink
Revert "tests(accessibility): Remove unused browser goldens (#758)" (#…
Browse files Browse the repository at this point in the history
…763)

Not dead code, this caused these tests to fail in firefox.
Reverts #758
  • Loading branch information
JoelEinbinder committed Jan 30, 2020
1 parent d590ab9 commit f4640d1
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions test/accessibility.spec.js
Expand Up @@ -234,10 +234,18 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
this is the inner content
<img alt="yo" src="fakeimg.png">
</div>`);
const golden = {
const golden = FFOX ? {
role: 'textbox',
name: 'my favorite textbox',
value: 'this is the inner content yo'
} : CHROMIUM ? {
role: 'textbox',
name: 'my favorite textbox',
value: 'this is the inner content '
} : {
role: 'textbox',
name: 'my favorite textbox',
value: 'this is the inner content ',
};
const snapshot = await page.accessibility.snapshot();
expect(snapshot.children[0]).toEqual(golden);
Expand All @@ -262,7 +270,11 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
this is the inner content
<img alt="yo" src="fakeimg.png">
</div>`);
const golden = {
const golden = FFOX ? {
role: 'checkbox',
name: 'this is the inner content yo',
checked: true
} : {
role: 'checkbox',
name: 'this is the inner content yo',
checked: true
Expand Down

0 comments on commit f4640d1

Please sign in to comment.