Skip to content

Commit

Permalink
doc(troubleshooting): add note about lack of node 8 support (#623)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoelEinbinder committed Jan 24, 2020
1 parent 03f37bc commit ff87701
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions docs/troubleshooting.md
Expand Up @@ -12,6 +12,7 @@
* [Running Playwright in Docker](#running-playwright-in-docker)
- [Tips](#tips)
- [Code Transpilation Issues](#code-transpilation-issues)
- [ReferenceError: URL is not defined](#referenceerror-url-is-not-defined)
<!-- GEN:stop -->
## Chromium

Expand Down Expand Up @@ -288,6 +289,10 @@ await page.evaluate(`(async() => {
})()`);
```

## ReferenceError: URL is not defined

Playwright requires node 10 or higher. Node 8 is not supported, and will cause you to recieve this error.

# Please file an issue

Playwright is a new project, and we are watching the issues very closely. As we solve common issues, this document will grow to include the common answers.
2 changes: 1 addition & 1 deletion utils/doclint/check_public_api/JSBuilder.js
Expand Up @@ -30,7 +30,7 @@ function checkSources(sources, externalDependencies) {
const classEvents = new Map();
const eventsSources = sources.filter(source => source.name().startsWith('events.ts'));
for (const eventsSource of eventsSources) {
const {Events} = require(eventsSource.filePath().endsWith('.js') ? eventsSource.filePath() : eventsSource.filePath().replace('/src/', '/lib/').replace('.ts', '.js'));
const {Events} = require(eventsSource.filePath().endsWith('.js') ? eventsSource.filePath() : eventsSource.filePath().replace(/\bsrc\b/, 'lib').replace('.ts', '.js'));
for (const [className, events] of Object.entries(Events))
classEvents.set(className, Array.from(Object.values(events)).filter(e => typeof e === 'string').map(e => Documentation.Member.createEvent(e)));
}
Expand Down

0 comments on commit ff87701

Please sign in to comment.