Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add more entries to response.securityDetails (and HAR output) #14754

Closed
Rafiot opened this issue Jun 9, 2022 · 4 comments
Closed

Comments

@Rafiot
Copy link

Rafiot commented Jun 9, 2022

The method response.securityDetails returns a few details regarding the certificate, but I'd love to get a few more, especially hashes of the certificate and/or the complete certificate itself (maybe as an option?).

I want to use it in PlaywrightCapture (via the HAR output) and ultimately in lookyloo in order to display more information about the page we're investigating. I think having that feature available in response.securityDetails would be useful for many other people than me.

Down the line, I'd like to push the certificates captured on lookyloo to CIRCL passive SSL service, which will require the full certificate.

@rwoll
Copy link
Member

rwoll commented Jun 9, 2022

Relates #6759

@pavelfeldman
Copy link
Member

Could you be more specific as to what you would like to see? This largely falls outside of the Playwright scope, so unless it is needed for testing, we are likely to close it.

@Rafiot
Copy link
Author

Rafiot commented Jun 9, 2022

It definitely relates to #6759. I'd like to be able to get the serial number and the hashes (sha1 and sha256, at least) in response.securityDetails (and in the HAR export). The full certificate is definitely optional (but nice to have if possible).

I'm not using Playwright for testing, but that sounds like a useful information for testing to me?

@pavelfeldman
Copy link
Member

Folding into #6759!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants