Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Linux WebKit Connection Details Feature Parity (TLS info, Cert Info) #6759

Closed
rwoll opened this issue May 26, 2021 · 3 comments
Closed

Comments

@rwoll
Copy link
Member

rwoll commented May 26, 2021

While working through #6624 / #6631 it became apparent that on Linux WebKit there are many connection and certificate details missing (like protocol, subjectName, validFrom, validTo, etc.) as WebKit has no way to currently populate the fields from libsoup.

This is an upstream issue: WebKit > libsoup > glib > glib-networking but cross-filing here to track bringing in the changes to Playwright WebKit for more feature parity with the other platforms:

  1. Add subject-name, issuer-name, not-valid-before, not-valid-after (glib PR / glib-networking PR)
  2. add protocol-version, ciphersuite-name (glib PR / glib-networking PR)

Feel free to assign to me as the first sent of linked glib* PRs are from me; I'm happy coordinate with the second set and intend to see the change through to WebKit (in Playwright's patched build or upstream depending on what a fully upstreamed WK patch entails).

Relates: #6624
Relates: #6631
Relates: Playwright Slack Thread

gnomesysadmins pushed a commit to GNOME/glib that referenced this issue Jun 10, 2021
This changeset exposes

* `dns-names`
* `ip-addresses`

on GTlsCertificate provided by the underlying TLS Backend.

See https://gitlab.gnome.org/GNOME/glib-networking/-/merge_requests/165 for the corresponding glib-networking changes.

Relates: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2113
Relates: https://gitlab.gnome.org/GNOME/glib-networking/-/merge_requests/156/diffs
Relates: microsoft/playwright#6759
@rwoll
Copy link
Member Author

rwoll commented Dec 12, 2021

These patches ended up making it into glib 2.70 which should ship with Ubuntu 22.04 (April 2022). Once those are there, I can patch up Linux WK accordingly if someone else has not yet integrated the changes. (I don't want anyone to have to compile glib from scratch, so, IMO, it doesn't make sense to patch WK until next year.)

@mcatanzaro
Copy link

mcatanzaro commented Dec 12, 2021

WebKit is not going to be allowed to depend on GLib 2.70 for a long time (several years). You're going to need to guard the new code with #if GLIB_CHECK_VERSION(2, 70, 0). You can do that whenever.

@pavelfeldman
Copy link
Member

Why was this issue closed?

Thank you for your involvement. This issue was closed due to limited engagement (upvotes/activity), lack of recent activity, and insufficient actionability. To maintain a manageable database, we prioritize issues based on these factors.

If you disagree with this closure, please open a new issue and reference this one. More support or clarity on its necessity may prompt a review. Your understanding and cooperation are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants