[BUG] npx playwright install does not finish install and exits with 0
#17394
Assignees
Comments
bpasero
changed the title
Executable doesn't exist at /Users/runner/Library/Caches/ms-playwright/chromium-1015/chrome-mac/Chromium.app/Contents/MacOS/Chromium
|
This is a known issue, that the download ( How often does it occur? You can try setting the Just FTR, your environment is macOS-11 with Node.js 16.17.0. |
mxschmitt
changed the title
Executable doesn't exist at /Users/runner/Library/Caches/ms-playwright/chromium-1015/chrome-mac/Chromium.app/Contents/MacOS/Chromiumnpx playwright install does not finish install and exits with 0
|
I would say we never had this issue before it only started relatively recently. Can playwright print more info from the install command? |
|
Yes as per above, if you set the DEBUG=pw:install env var. |
|
@mxschmitt we had 2 cases now after I added logging. Case 1 Error: Logs: Case 2 Error: Logs: |
|
Another one: |
|
Is there a command to verify the success of playwright install that we could maybe run to retry this? |
|
Btw our install script calls |
|
One idea is that it was maybe caused by using |
Our current assumption after debugging this a bit with clients is that we hit a Node.js segfault. There are some upstream issues, especially about dealing with network ends up in crashes referring to my colleague. So we'd now recommend using a Node.js debug build in the hope that a stack trace gets printed when it happens. I can compile one for you, upload it to azure blob and we can use this one exclusively only for the e2e tests, and there only for downloading the browsers. Would you be fine with that? |
|
We need to consume playwright via |
The problem is not Playwright. It's most likely Node.js. what we know as of today is sometimes it will just exit with 0 without triggering any error handlers etc. We can make npm consume a custom node.js executable. But it's enough to call the installPlaywright.js in your case with the custom node which is compiled with debug mode, so no need for npm stuff. |
|
I am not sure we can patch the node.js executable that is used by Azure CI to be honest. |
It would be something like that: curl... I can prepare the stuff later, it hopefully gives us more insights. It's also affecting macOS only. If you have suggestions how to debug it, let us know! That would be for us at least the next logical step. |
|
So it seems the log is indicating the issue, e.g. here: The bar does not finish. Are there debug flags we could enable in node.js? If there is nothing, then yeah, lets see to hack in the node.js executable, maybe in a branch of VSCode. Should be easy enough to reproduce there as well. |
|
Interesting, on Linux: |
Most likely not, I'm currently compiling Node.js for macOS, so we can use this to maybe get more information out of it.
That's helpful! So some issue seems to affect Linux as well. Pretty sure the issue on Linux is different tho, we recently fixed this, which should be included in the 1.26 release (not released yet). Reason was that there was no timeout set for the underlying http requests. |
|
Note that we are on |
This was referenced Sep 20, 2022
|
@bpasero We were seeing this on our CI machines and updating to |
Which operating system are you using and where do you run your tests? |
Sorry I don't know how to inspect the details of our agents. They are hosted in Azure DevOps. We are using the |
|
I will see to update to |
|
@nmann4 could you provide us some logs of your behavior? What was failing? Does it also just randomly stop the downloads or does it hang? Hanging should be fixed in 1.26. This issue is about that the download suddenly stops and does not yield to errors. Just to make sure we are talking about the same issues, since as of today we think this issue is macOS only, but you are using Linux so this would make a big difference! |
|
@mxschmitt Sure. Sorry if I hijacked the thread. To be clear we were seeing the downloads being stuck at 0 and then it would still report the build as a "success". Then the tests would fail because there was no browser installed. Here is a snippet from the machine. it was reproing consistently in CI. Let me know if you need more logs from before and after this moment. EDIT: |
|
I also feel that the update has helped us, so maybe that was the fix needed? However, that does still not explain how it suddenly started, because we had been on the |
mxschmitt
added a commit
that referenced
this issue
Sep 28, 2022
mxschmitt
added a commit
that referenced
this issue
Sep 30, 2022
|
We implemented like a workaround for this, it goes live in 1.27. Please let us know if you still encounter it afterwards. |
|
There is still a problem. you helped me**** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Edit from maintainers
You are affected when
npx playwright installdoes not produce aline for each browser install and stops already before.
We recently see this in our CI (using
playwright@1.24.2):Is this known?
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=185457&view=logs&j=a5d99aad-4929-5289-bf4a-26b78032353d&t=dafdf52c-6fc3-5431-f55d-37c3624b5ac3&l=13
//cc @pavelfeldman
The text was updated successfully, but these errors were encountered: