-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] WebKit doesn't play webm files on MacOS #18423
Comments
Plus, if I refer to this comment, the version used to be higher (14, at the time), so something must be wrong with the current build. |
Relatedly, WebKit on Linux is reporting version 16. It does play WebM. On the other hand, it doesn't have To sum up, taking the latest builds on each platform:
I don't know how Playwright WebKit was built. I'll have a look at the browser_patches directory, but any help would be welcome. |
@warrenseine how do you check the user agent? For example, the following yields a proper user agent for me. // a.mjs
import { webkit } from '@playwright/test';
const browser = await webkit.launch();
const page = await browser.newPage();
console.log(await page.evaluate(() => navigator.userAgent));
// Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.0 Safari/605.1.15
await browser.close(); If you use the WebKit Web Inspector, then user agent will reset to some old value. Unfortunately, this is a known issue. |
Yes, I used the Web Inspector. If it is indeed version 16, can you confirm that WebM is not supported? Any reason why we see these differences in feature support? |
@warrenseine the WebM should be supported on MacOS; I indeed see it doesn't play. We'll take a look. |
Cool, thanks! I'll try a nightly soon. |
I can confirm that playback works now, thanks! Unfortunately, I've discovered another WebM-specific issue (#20489). Please have a look! |
Triaging summary from @aslushnikov: WebKit doesn't play webm files on MacOS.
Context:
Describe the bug
The WebKit version fetched by Playwright has an unexpected user agent (reported with
navigator.userAgent
):In particular, I would expect
Version/16.0
, which I correctly get with my default Safari. With a manually installed Safari Technology Preview, I getVersion/16.4
.I've tried cleaning caches and fetching it again:
I suspect that the current build is not actually WebKit 16, but WebKit 13. I cannot be sure although WebM video playback support (don't play in this build, plays in official Safari and STP) seems to confirm it.
I've also tried forcing build 1728 (latest unreleased) to no avail.
The text was updated successfully, but these errors were encountered: