Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support TypeScript's --moduleResolution bundler #22169

Closed
dgozman opened this issue Apr 3, 2023 · 1 comment · Fixed by #22887
Closed

[Feature] Support TypeScript's --moduleResolution bundler #22169

dgozman opened this issue Apr 3, 2023 · 1 comment · Fixed by #22887
Assignees
@dgozman
Labels
v1.34

Comments

@dgozman
Copy link
Contributor

dgozman commented Apr 3, 2023

Copying from #19710 (comment) by @danieldiekmeier:

In TypeScript 5.0, there (probably) will be a new module resolution option: --moduleResolution bundler: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#moduleresolution-bundler

I installed the TypeScript 5.0 Beta because I also want to use imports without extensions in Playwright. Sadly, it still does not seem to work. Are there plans to update Playwright to also support --moduleResolution bundler?
@dgozman dgozman added the v1.34 label Apr 3, 2023
@dgozman dgozman self-assigned this Apr 3, 2023
@dgozman dgozman mentioned this issue Apr 3, 2023
Closed
@kristojorg
Copy link
Contributor

In general it would be nice to have more of the transpiler exposed to users to change as needed.

@dgozman dgozman mentioned this issue May 8, 2023
Merged
dgozman added a commit that referenced this issue May 9, 2023
@dgozman
feat(typescript): align with --moduleResolution=bundler (#22887)
cd49f5c 
This relaxes import requirements and allows importing `.ts` files
without an extension in CJS and ESM modes.

Fixes #22169.
@dgozman dgozman mentioned this issue Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
v1.34
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(typescript): align with --moduleResolution=bundler dgozman/playwright
2 participants
@kristojorg @dgozman