[REGRESSION]: Snapshot styles in trace-viwer aren't loaded #24144
Labels
Comments
|
@fadezak100 Any chance for a repro we can run locally, or a trace.zip that exhibits this issue? |
|
@dgozman Sure the one I have right now has a LinkedIn account credentials I will try to generate one for you. Or if I can send the one I already have privately? |
|
@fadezak100 You can send it to dgozman [at] microsoft [dot] com |
|
@dgozman sent. |
dgozman
added a commit
that referenced
this issue
Jul 11, 2023
Fixes #24144. Previously, we only matched by url, which confuses GET and HEAD requests where the latter is usually zero-sized. Also make sure that resources are sorted by their monotonicTime, since that's not always the case in the trace file, where they are sorted by the "response body retrieved" time.
dgozman
added a commit
to dgozman/playwright
that referenced
this issue
Jul 11, 2023
Fixes microsoft#24144. Previously, we only matched by url, which confuses GET and HEAD requests where the latter is usually zero-sized. Also make sure that resources are sorted by their monotonicTime, since that's not always the case in the trace file, where they are sorted by the "response body retrieved" time.
aslushnikov
pushed a commit
that referenced
this issue
Jul 11, 2023
Fixes #24144. Previously, we only matched by url, which confuses GET and HEAD requests where the latter is usually zero-sized. Also make sure that resources are sorted by their monotonicTime, since that's not always the case in the trace file, where they are sorted by the "response body retrieved" time.
|
@fadezak100 Could you please try |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this issue
Oct 27, 2023
Fixes microsoft#24144. Previously, we only matched by url, which confuses GET and HEAD requests where the latter is usually zero-sized. Also make sure that resources are sorted by their monotonicTime, since that's not always the case in the trace file, where they are sorted by the "response body retrieved" time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context:
Code Snippet
I was running a local version of trace-viewer. I had earlier generated some
trace.zipreports from a playwright test. After loading the tests on the trace-viewer, I noticed that in most of the reports, snapshot styles were missing.Describe the bug
When loading a
trace.zipinto the local trace-viewer package some of the snapshot styles resources aren't loaded. When inspecting the network requests I found out that all of the CSS files were returned but some of them were empty.The live trace viewer which is still on 1.35.0 I believe:
The text was updated successfully, but these errors were encountered: