Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Disable firefox auto translate popup by default #27741

Closed
atomfrede opened this issue Oct 22, 2023 · 1 comment · Fixed by #27794
Closed

[Feature] Disable firefox auto translate popup by default #27741

atomfrede opened this issue Oct 22, 2023 · 1 comment · Fixed by #27794

Comments

@atomfrede
Copy link

With the latest firefox supports auto translations. By default the auto translate popup will be shown (e.g. my os is in english, but I test websites in german). It can happen, that the auto translate popup is shown above elements you need to click. In that case the test fails.
In particular for me it looked like a regression, because tests worked fine until the recent update.

One can set it manually via

 launchOptions: {
      firefoxUserPrefs: {
        "browser.translations.automaticallyPopup": false,
        "browser.translations.enable": false, 
      }
    }

but I think it would be a good default.

image

@atomfrede
Copy link
Author

@mxschmitt If you like I can do a PR too (it looks like a pretty small change in /playwright.cfg if I am not mistaken).

mxschmitt pushed a commit that referenced this issue Oct 25, 2023
Fixes #27741

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
Fixes microsoft#27741

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants