Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Show the Test Annotation in the Merged Report Even Though the Test are Being Skipped #30260

Closed
aldys33 opened this issue Apr 5, 2024 · 5 comments · Fixed by #30348
Assignees
Labels

Comments

@aldys33
Copy link

aldys33 commented Apr 5, 2024

🚀 Feature Request

I just notice that if my test got skipped, the annotation is missing from the report. This only happen when I use merge-report, which is I'm utilizing sharding.
image


I think it's better to have annotation still got attached in the report, despite the test being success, failed, or even skipped as well for the merged report.

Example

Condition when the test got skipped

image

Condition when the test is failed/success

image

Motivation

I believe there are user that utilize annotation for several purpose. Like for me, it is a place to store Test ID that connects with the AIO. So it's important to preserve the annoation in the report regardless of how the test execution is going

@aldys33 aldys33 changed the title [Feature]: Show the Test Annotation in the Report Even Though the Test are Being Skipped [Feature]: Show the Test Annotation in the Merged Report Even Though the Test are Being Skipped Apr 5, 2024
@dgozman
Copy link
Contributor

dgozman commented Apr 5, 2024

@aldys33 Could you please share a repro exhibiting the issue that we can run locally?

@aldys33
Copy link
Author

aldys33 commented Apr 6, 2024

yeah, will create a repo to demonstrate on that one

@aldys33
Copy link
Author

aldys33 commented Apr 8, 2024

@dgozman Please refer to the following repo https://github.com/aldys33/Playwright.Annotation.Demo/actions
I did create a sample run with and without sharding. Please note that when using sharding, the annotation is not showing

@dgozman
Copy link
Contributor

dgozman commented Apr 8, 2024

@aldys33 Thank you for the repro, I can see the bug now.


Investigation notes: a test is skipped in one of the shards and there is no onTestEnd event in the blob reporter that contains annotations.

@aldys33
Copy link
Author

aldys33 commented Apr 8, 2024

Thanks, @dgozman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants