Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] route.fulfill doesn't update cookies from Set-Cookie header #4987

Closed
yury-s opened this issue Jan 12, 2021 · 1 comment
Closed

[BUG] route.fulfill doesn't update cookies from Set-Cookie header #4987

yury-s opened this issue Jan 12, 2021 · 1 comment
Assignees

Comments

@yury-s
Copy link
Member

yury-s commented Jan 12, 2021

Context:

  • Playwright Version: 1.8-next

Code Snippet

The following snippet works only in Chromium but not in Firefox or WebKit.

  await page.route('https://example.com/', (route, request) => {
    route.fulfill({
      headers: {
        'Set-Cookie': 'name=value; domain=.example.com; Path=/'
      },
      contentType: 'text/html',
      body: 'done'
    });
  });
  await page.goto('https://example.com');
  expect(await context.cookies()).toEqual([{
    sameSite: 'None',
    name: 'name',
    value: 'value',
    domain: '.example.com',
    path: '/',
    expires: -1,
    httpOnly: false,
    secure: false
  }]);
@dgozman dgozman removed the v1.9 label Feb 4, 2021
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 16, 2021
aslushnikov added a commit that referenced this issue Feb 16, 2021
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 20, 2021
@aslushnikov aslushnikov removed their assignment Feb 25, 2021
@pavelfeldman
Copy link
Member

Why was this issue closed?

We are prioritizing the bugs based on the upvotes, recency and our ability to act. It looks like this issue only has a handful of upvotes, has not been touched recently and/or we lack sufficient feedback to act on it. We are closing issues like this one to keep our bug database maintainable. Please feel free to open a new issue and link this one to it if you think this is a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants