Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: follow-up with ffmpeg downloads to registry #5278

Closed
1 of 2 tasks
aslushnikov opened this issue Feb 3, 2021 · 0 comments · Fixed by #5318
Closed
1 of 2 tasks

chore: follow-up with ffmpeg downloads to registry #5278

aslushnikov opened this issue Feb 3, 2021 · 0 comments · Fixed by #5318
Assignees
@aslushnikov
Labels
P1-resolve-asap

Comments

@aslushnikov
Copy link
Collaborator

aslushnikov commented Feb 3, 2021 •
edited

  • include license to FFMPEG archive
  • code cleanup: move packagePath var to playwrightOptions
@aslushnikov aslushnikov self-assigned this Feb 3, 2021
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 4, 2021
@aslushnikov
devops: bundle ffmpeg license file with our archives
8f15b2b 
References microsoft#5278
@aslushnikov aslushnikov mentioned this issue Feb 4, 2021
Merged
aslushnikov added a commit that referenced this issue Feb 4, 2021
@aslushnikov
devops: bundle ffmpeg license file with our archives (#5301)
d851bce 
References #5278
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 4, 2021
@aslushnikov
feat(ffmpeg): roll FFMPEG to r1005
c538332 
Drive-By: update `//utils/roll_browser.js` script to support FFMPEG

References microsoft#5278
@aslushnikov aslushnikov mentioned this issue Feb 4, 2021
Merged
aslushnikov added a commit that referenced this issue Feb 4, 2021
@aslushnikov
feat(ffmpeg): roll FFMPEG to r1005 (#5303)
3c36322 
Drive-By: update `//utils/roll_browser.js` script to support FFMPEG

References #5278
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 4, 2021
@aslushnikov
refactor: cleanup browsersPath
4c7997e 
This patch:
- inlines `packagePath` into `PlaywrightOptions`
- renames `browserPaths.browsersPath` to `browserPaths.registryPath` to
avoid confusion. All `browsersPath` variables are renamed to
`registryPath` too.
- introduces a single `browserPaths.resolvePaths()` method that resolves
all paths given only `packagePath` and browser descriptor.

Fixes microsoft#5278
@aslushnikov aslushnikov mentioned this issue Feb 4, 2021
Merged
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 5, 2021
@aslushnikov
refactor: remove browserPaths in favor of Registry class
af14e8d 
This patch introduces a new Registry class that incapsulates
all logic regarding browsers and their paths.

Fixes microsoft#5278
aslushnikov added a commit that referenced this issue Feb 9, 2021
@aslushnikov
refactor: remove browserPaths in favor of Registry class (#5318)
d499cf0 
This patch introduces a new Registry class that incapsulates
all logic regarding browsers and their paths.

Fixes #5278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
P1-resolve-asap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove browserPaths in favor of Registry class aslushnikov/playwright
1 participant
@aslushnikov