Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trace viewer] srcset sanitization removes space between values, hence breaks the links #6982

Closed
pavelfeldman opened this issue Jun 9, 2021 · 0 comments · Fixed by #6995
Closed

[trace viewer] srcset sanitization removes space between values, hence breaks the links #6982

pavelfeldman opened this issue Jun 9, 2021 · 0 comments · Fixed by #6995

Comments

@pavelfeldman
Copy link
Member 

srcset="https://static.rdc.moveaws.com/images/hero/default/2021-2/hp-hero-desktop-1440w.webp,
            https://static.rdc.moveaws.com/images/hero/default/2021-2/hp-hero-desktop-2880w-2x.webp 2x"

srcset="https://static.rdc.moveaws.com/images/hero/default/2021-2/hp-hero-desktop-1440w.webp,https://static.rdc.moveaws.com/images/hero/default/2021-2/hp-hero-desktop-2880w-2x.webp 2x"
@pavelfeldman pavelfeldman mentioned this issue Jun 9, 2021
Merged
aslushnikov pushed a commit that referenced this issue Jun 9, 2021
@pavelfeldman
fix(tracing): do not merge srcset urls (#6995)
19d69b7 
Fixes #6982
aslushnikov pushed a commit to aslushnikov/playwright that referenced this issue Jun 9, 2021
@pavelfeldman @aslushnikov
cherry-pick(release-1.12): do not merge srcset urls
cb0889e 
Cherry-pick PR microsoft#6995 SHA 19d69b7

References microsoft#6982
@aslushnikov aslushnikov mentioned this issue Jun 9, 2021
Merged
aslushnikov added a commit that referenced this issue Jun 9, 2021
@aslushnikov @pavelfeldman
cherry-pick(release-1.12): do not merge srcset urls (#6997)
0d845e0 
Cherry-pick PR #6995 SHA 19d69b7

References #6982

Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tracing): do not merge srcset urls pavelfeldman/playwright
1 participant
@pavelfeldman