Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Firefox: bundle ff-specific preferences with binary #857

Closed
aslushnikov opened this issue Feb 6, 2020 · 0 comments · Fixed by #943
Closed

[BUG] Firefox: bundle ff-specific preferences with binary #857

aslushnikov opened this issue Feb 6, 2020 · 0 comments · Fixed by #943

Comments

@aslushnikov
Copy link
Collaborator

We currently try putting firefox preferences in the userDataDir when launching firefox. This doesn't work well if users provide custom userDataDir - we may corrupt their preferences.

Instead, we should put preferences next to binaries during build stage.
@pavelfeldman pavelfeldman mentioned this issue Feb 11, 2020
Closed
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Feb 12, 2020
@aslushnikov
fix(firefox): rely on bundled firefox preferences
4c83b35 
Since Firefox r1027 we bundle preferences alongside with build.

Fixes microsoft#857
@aslushnikov aslushnikov mentioned this issue Feb 12, 2020
Merged
aslushnikov added a commit that referenced this issue Feb 12, 2020
@aslushnikov
fix(firefox): rely on bundled firefox preferences (#943)
0d16d14 
Since Firefox r1027 we bundle preferences alongside with build.

Fixes #857
@Shinoby92 Shinoby92 mentioned this issue Nov 9, 2020
Closed
sand4rt pushed a commit to sand4rt/playwright that referenced this issue Dec 21, 2022
@pavelfeldman
chore: merge usage blocks (microsoft#857)
4d7d1a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(firefox): rely on bundled firefox preferences aslushnikov/playwright
2 participants
@aslushnikov @pavelfeldman