Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): trace context APIRequest calls #10684

Merged
merged 2 commits into from
Dec 2, 2021
Merged

feat(tracing): trace context APIRequest calls #10684

merged 2 commits into from
Dec 2, 2021

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Dec 2, 2021

@yury-s yury-s requested a review from dgozman December 2, 2021 21:19
dgozman
dgozman approved these changes Dec 2, 2021
View reviewed changes
packages/playwright-core/src/server/supplements/har/harTracer.ts
headers: [],
content: {
size: -1,
mimeType: request.headerValue('content-type') || 'x-unknown',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value has changed to just 'x-unknown'. Is that a problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, setting response's mime type to that of the request seems wrong.

packages/playwright-core/src/server/fetch.ts Show resolved Hide resolved
@yury-s yury-s merged commit 8afd0b7 into microsoft:master Dec 2, 2021
@yury-s yury-s deleted the fetch-har branch December 2, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yury-s @dgozman