feat: support PLAYWRIGHT_DOWNLOAD_HOST
#1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch starts respecting `PLAYWRIGHT_DOWNLOAD_HOST` env variable in `playwright` package and it's vendored flavors (`playwright-firefox`, `playwright-chromium` and `playwright-webkit`). Fixes microsoft#1045
aslushnikov
force-pushed
the
respect-environment-variables
branch
from
e761e5b
to
2125f12
Compare
dgozman
approved these changes
Mar 2, 2020
| @@ -203,7 +205,7 @@ export class WebKit implements BrowserType { | |||
|
|
|||
| const defaultOptions = { | |||
There was a problem hiding this comment.
Should we follow up with removing BrowserFetcherOptions? We do not use anything but default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts respecting
PLAYWRIGHT_DOWNLOAD_HOSTenv variablein
playwrightpackage and it's vendored flavors (playwright-firefox,playwright-chromiumandplaywright-webkit).Fixes #1045