Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: expand TypeScript doc with modules and path mappings #13567

Merged
merged 1 commit into from
Apr 14, 2022
Merged

docs: expand TypeScript doc with modules and path mappings #13567

merged 1 commit into from
Apr 14, 2022

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Apr 14, 2022

Fixes #13515.

rwoll
rwoll approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@rwoll rwoll left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider using : instead of . with each direction leading to a code block.

i.e.

- Consider this helper module written in TypeScript.
+ Consider this helper module written in TypeScript:

docs/src/test-typescript-js.md Outdated Show resolved Hide resolved
@dgozman dgozman merged commit 634f40e into microsoft:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwoll rwoll rwoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ESM: imports don't work [ERR_MODULE_NOT_FOUND] and [ERR_UNSUPPORTED_DIR_IMPORT]
2 participants
@dgozman @rwoll