fix(test-runner): worker churn with fullyParallel #13584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we were pre-maturely stopping a worker (since it was deemed redundant under a race condition), and then we immeditely created a new worker with the same hash to finish off the test run. The worker creation is expensive, so this slowed down the overall test run time. See the following for logs of the old code illustrating the extra stops and starts: https://gist.github.com/rwoll/1c592ed9e8f9169274fa972674de6703
pavelfeldman
approved these changes
Apr 15, 2022
dgozman
approved these changes
Apr 16, 2022
rwoll
added a commit
to rwoll/playwright
that referenced
this pull request
Apr 17, 2022
…Parallel Prior to this change, we were pre-maturely stopping a worker (since it was deemed redundant under a race condition), and then we immediately created a new worker with the same hash to finish off the test run. The worker creation is expensive, so this slowed down the overall test run time. See the following for logs of the old code illustrating the extra stops and starts: https://gist.github.com/rwoll/1c592ed9e8f9169274fa972674de6703
aslushnikov
pushed a commit
that referenced
this pull request
Apr 18, 2022
…13597) Prior to this change, we were pre-maturely stopping a worker (since it was deemed redundant under a race condition), and then we immediately created a new worker with the same hash to finish off the test run. The worker creation is expensive, so this slowed down the overall test run time. See the following for logs of the old code illustrating the extra stops and starts: https://gist.github.com/rwoll/1c592ed9e8f9169274fa972674de6703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we were pre-maturely stopping workers (since they
were deemed redundant under a race condition), and then we immediately
created a new worker with the same hash to finish off the test run. The
worker creation is expensive, so this slowed down the overall test run
time.
See the following for logs of the old code illustrating the extra stops and starts: https://gist.github.com/rwoll/1c592ed9e8f9169274fa972674de6703