Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chromium): remove CRTarget, use CRPage and CRServiceWorker instead #1436

Merged
merged 1 commit into from Mar 24, 2020
Merged

chore(chromium): remove CRTarget, use CRPage and CRServiceWorker instead #1436

merged 1 commit into from Mar 24, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Mar 20, 2020

No description provided.

@dgozman dgozman requested a review from yury-s March 20, 2020 04:44
@pavelfeldman
Copy link
Member

Looks good. Why do we want it though? As long as there is Target in CDP, I would expect us to use its counterpart in the front-end.

@dgozman
Copy link
Contributor Author

dgozman commented Mar 20, 2020

Looks good. Why do we want it though? As long as there is Target in CDP, I would expect us to use its counterpart in the front-end.

I thought the same, but as it turned out, current CRTarget is just a class with targetId. The rest is handled by CRPage.

yury-s
yury-s approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

src/chromium/crBrowser.ts Outdated Show resolved Hide resolved
src/chromium/crBrowser.ts Outdated Show resolved Hide resolved
@dgozman dgozman merged commit 7ef394b into microsoft:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgozman @pavelfeldman @yury-s