browser(firefox): implement Browser.addBinding #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
changed the title
pavelfeldman
force-pushed
the
be_exposeFunction
branch
from
c6fd0b1
to
9bc8d21
Compare
dgozman
approved these changes
Mar 23, 2020
dgozman
reviewed
Mar 23, 2020
| + }, frame.domWindow(), { | ||
| + defineAs: name, | ||
| + }); | ||
| + frame.domWindow().eval(script); |
There was a problem hiding this comment.
Should we use mainContext.evaluate instead to circumvent CSP? Similar to scripts to evaluate on load.
There was a problem hiding this comment.
I can't get ahold of it from there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pavelfeldman/gecko-dev@a54d15a