fix: do not throw on removeListener without listener #15224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
fix-event-emitter-remove-listener
branch
from
4ab0549
to
9ba5a32
Compare
aslushnikov
reviewed
Jun 29, 2022
aslushnikov
approved these changes
Jun 29, 2022
Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Jun 29, 2022
…hout listener SHA: b3c31f5
mxschmitt
added a commit
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15219