chore: speedup npm install from a github checkout
#1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of us are running a watchdog in the background that keeps `//lib` folder up-to-date, so there's no need to re-build Playwright from source on every `npm install` command. This patch does a crude timestatmp comparison between typescript files and their javascript counterparts. If some files are missing in `//lib`, or if some `//src` files are newer than `//lib`, then it re-builds the Playwright. This cuts off 10 seconds for me on in case I have a watchdog in the background.
dgozman
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of us are running a watchdog in the background that
keeps
//libfolder up-to-date, so there's no need to re-buildPlaywright from source on every
npm installcommand.This patch does a crude timestatmp comparison between typescript
files and their javascript counterparts. If some files are missing in
//lib, or if some//srcfiles are newer than//lib, thenit re-builds the Playwright.
This cuts off 10 seconds for me on in case I have a watchdog in the
background.