Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): update ordering for $eval and $$eval #1623

Merged
merged 2 commits into from Apr 1, 2020

Conversation

arjunattam
Copy link
Contributor

...to be consistent with how we order $ and $$ - the inconsistency has been bothering me. However, this fails on doc lint. I could update the linter along with this.

DocLint Failures:
  1) [MarkDown] Bad alphabetic ordering of Page members: Page.$eval() should go after Page.$$eval()
  2) [MarkDown] Bad alphabetic ordering of Frame members: Frame.$eval() should go after Frame.$$eval()
  3) [MarkDown] Bad alphabetic ordering of ElementHandle members: ElementHandle.$eval() should go after ElementHandle.$$eval()

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, please go ahead and update the liner.

@arjunattam
Copy link
Contributor Author

I learnt something new about JS strings. $ < $$, but $eval > $$eval. I've updated doclint to replace multiple occurrences of $ with one.

@dgozman dgozman merged commit 1f0b7bf into microsoft:master Apr 1, 2020
@arjunattam arjunattam deleted the 65711-eval branch April 1, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants