docs: Trace-viewer-intro #16254
Merged
docs: Trace-viewer-intro #16254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
debs-obrien
commented
Aug 4, 2022
•
debs-obrien
commented
mxschmitt
reviewed
Aug 9, 2022
| context = await browser.new_context() | ||
|
|
||
| # Start tracing before creating / navigating a page. | ||
| await context.tracing.start(screenshots=True, snapshots=True, sources=True) |
There was a problem hiding this comment.
We should mention the pytest plugin way there instead of the library approach.
There was a problem hiding this comment.
you will have to add what you mean here as no idea what the pytest plugin way is
There was a problem hiding this comment.
https://playwright.dev/python/docs/test-runners
pytest --trace on
| Available options to record a trace: | ||
| - `'on-first-retry'` - Record a trace only when retrying a test for the first time. |
There was a problem hiding this comment.
Mention to make sure to have retries >= 1?
There was a problem hiding this comment.
This doc needs a full rework which will be part of another pr
mxschmitt
approved these changes
Aug 10, 2022
mxschmitt
pushed a commit
to mxschmitt/playwright
that referenced
this pull request
Aug 10, 2022
mxschmitt
added a commit
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.