Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(har): record request overrides to har #17027

Merged
merged 7 commits into from
Sep 4, 2022

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 2, 2022

Trace recorder still writes original request to ensure that it is properly replayed when showing the resources in the trace viewer as there is no page.route logic.

Fixes #16815

@yury-s yury-s merged commit 01d83f1 into microsoft:main Sep 4, 2022
@yury-s yury-s deleted the har-request-overrides branch September 4, 2022 17:52
rwoll added a commit to microsoft/playwright-python that referenced this pull request Sep 20, 2022
Ports:

  - [x] microsoft/playwright@a07a4a2 (chore: make parent scope explicit (microsoft/playwright#16819))
  - [x] microsoft/playwright@306ab34 (feat(assertions): support toBeEnabled({ enabled }) (microsoft/playwright#17058))
  - [x] microsoft/playwright@f0c5810 (feat(assertions): support toBeEditable({ editable }) (microsoft/playwright#17065))
  - [x] microsoft/playwright@bca13bc (feat(assertions): support toBeVisible({ visible }) (microsoft/playwright#17207))
  - [x] microsoft/playwright@17b203a (feat: added follow and redirect arguments to fetch (microsoft/playwright#17033))
- [x] microsoft/playwright@fea8772 (fix: emit load/domcontentloaded events as reported by the browser)
- [x] microsoft/playwright@01d83f1 (fix(har): record request overrides to har (microsoft/playwright#17027))
sbakerdev added a commit to sbakerdev/playwright-python that referenced this pull request Nov 29, 2022
Ports:

  - [x] microsoft/playwright@a07a4a2 (chore: make parent scope explicit (microsoft/playwright#16819))
  - [x] microsoft/playwright@306ab34 (feat(assertions): support toBeEnabled({ enabled }) (microsoft/playwright#17058))
  - [x] microsoft/playwright@f0c5810 (feat(assertions): support toBeEditable({ editable }) (microsoft/playwright#17065))
  - [x] microsoft/playwright@bca13bc (feat(assertions): support toBeVisible({ visible }) (microsoft/playwright#17207))
  - [x] microsoft/playwright@17b203a (feat: added follow and redirect arguments to fetch (microsoft/playwright#17033))
- [x] microsoft/playwright@fea8772 (fix: emit load/domcontentloaded events as reported by the browser)
- [x] microsoft/playwright@01d83f1 (fix(har): record request overrides to har (microsoft/playwright#17027))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] routeFromHar with update:true doesn't respect advanced routing order
2 participants