Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devops: use node 10 on appveyor #1714

Merged
merged 1 commit into from Apr 13, 2020
Merged

devops: use node 10 on appveyor #1714

merged 1 commit into from Apr 13, 2020

Conversation

aslushnikov
Copy link
Collaborator

No description provided.

@pavelfeldman
Copy link
Member

Our test harness requires Node 12, do you want to fix this as a part of the change?

pavelfeldman
pavelfeldman requested changes Apr 9, 2020
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see ^^

@dgozman
Copy link
Contributor

dgozman commented Apr 10, 2020

Our test harness requires Node 12, do you want to fix this as a part of the change?

I fixed that already.

@pavelfeldman pavelfeldman merged commit 3b23041 into microsoft:master Apr 13, 2020
@aslushnikov aslushnikov deleted the change-appveryour-node-version-to-10 branch April 23, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aslushnikov @pavelfeldman @dgozman