feat: introduce page.on('crash') event
#1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Apr 14, 2020
| @@ -104,19 +104,16 @@ describe('Async stacks', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Page.Events.error', function() { | |||
| describe('Page.Events.Crash', function() { | |||
There was a problem hiding this comment.
Let's add a test that you cannot do anything with the page after crash, and ensure that.
dgozman
approved these changes
Apr 14, 2020
aslushnikov
force-pushed
the
support-page-crash
branch
from
7e08740
to
057afdb
Compare
Currently, whenever the page crashes, it emits an `'error'` event. Error event is a special type of event in node.js; if unhandled, it crashes the process. Instead of emitting `'error'` event, this patch switches to emitting `'crash'` event. Playwright users are free to handle the event however they like, or just to ignore it.
aslushnikov
force-pushed
the
support-page-crash
branch
from
057afdb
to
83bc0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever the page crashes, it emits an
'error'event.Error event is a special type of event in node.js; if unhandled,
it crashes the process.
Instead of emitting
'error'event, this patch switches to emitting'crash'event. Playwright users are free to handle the eventhowever they like, or just to ignore it.