Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip a couple of a11y tests on Edge temporarily #18824

Merged
merged 1 commit into from
Nov 15, 2022
Merged

chore: skip a couple of a11y tests on Edge temporarily #18824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/page/page-accessibility.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,9 @@ it('should not report text nodes inside controls', async function({ page, browse
expect(await page.accessibility.snapshot()).toEqual(golden);
});

it('rich text editable fields should have children', async function({ page, browserName, browserVersion }) {
it('rich text editable fields should have children', async function({ page, browserName, browserVersion, channel }) {
it.skip(browserName === 'webkit', 'WebKit rich text accessibility is iffy');
it.skip(channel && channel.startsWith('msedge'), 'Edge is missing a Chromium fix');

await page.setContent(`
<div contenteditable="true">
Expand Down Expand Up @@ -174,8 +175,9 @@ it('rich text editable fields should have children', async function({ page, brow
expect(snapshot.children[0]).toEqual(golden);
});

it('rich text editable fields with role should have children', async function({ page, browserName, browserMajorVersion, browserVersion }) {
it('rich text editable fields with role should have children', async function({ page, browserName, browserMajorVersion, browserVersion, channel }) {
it.skip(browserName === 'webkit', 'WebKit rich text accessibility is iffy');
it.skip(channel && channel.startsWith('msedge'), 'Edge is missing a Chromium fix');

await page.setContent(`
<div contenteditable="true" role='textbox'>
Expand Down