fix(chromium): detach from shared workers #18976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents shared workers from stalling upon restart.
We receive
Inspector.targetCrashed
andInspector.targetReloadedAfterCrash
events that assumeRuntime.runIfWaitingForDebugger
from any attached client. It is easier and more stable to just detach from shared workers, because we do not inspect them.For service workers, we should actually issue
Runtime.runIfWaitingForDebugger
in such cases, because we attach to them.Fixes #18932.